Skip to content

Conversation

@robertjdominguez
Copy link
Collaborator

Description 📝

Quick Links 🚀

Assertion Tests 🤖

@robertjdominguez robertjdominguez merged commit 155ef8c into main Oct 8, 2025
3 of 4 checks passed
@hasura-bot
Copy link
Contributor

DX: Assertion Testing

✅ Diff

The PR replaces the Kaniko build step with a Docker build step which may simplify the build process and make it more familiar to developers used to Docker. The addition of 'automapSubstitutions' should help with variable substitution, and adding the 'images' section ensures the built images are properly registered with the Cloud Build. Overall, this change seems to increase the clarity and maintainability of the build steps.

❌ Integrated

While the PR changes the image building process, it does not appear to update any corresponding documentation or comments that might explain why Docker is now preferred over Kaniko in these files. This can lead to confusion for future maintainers. Additionally, it's unclear if other parts of the CI/CD pipeline rely on specific Kaniko features that Docker may not provide. Ensuring alignment with the entire CI/CD and providing adequate documentation for the change is necessary to fully meet the usability assertion.

@robertjdominguez robertjdominguez deleted the rob/chore/replace-kaniko branch October 8, 2025 18:42
@hasura-bot
Copy link
Contributor

@robertjdominguez Thanks for your PR! I've assigned @robertjdominguez to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants