-
Notifications
You must be signed in to change notification settings - Fork 347
Add c2hs mode #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c2hs mode #1199
Conversation
;; along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
;;; Commentary: | ||
;; This mode is mostly indended for highlighting {#...#} hooks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indended
— typo? (:
Fixed typo in the description. |
Would you like to add some tests? |
I think I'll add some font-lock tests |
Yes, please add some tests. These are required, otherwise we will not be able to take responsibility of this module. And thanks for great contribution! |
This is a wrapper around haskell-mode, that mostly adds fontification for {#...#} blocks.
Explicitly specify mode by function to set up in the buffer. Move check-properties to haskell-test-utils module so it can be reused for c2hs fontification tests.
I added tests for all hooks currently colorized and rebased against latest master |
Nice. Lets wait 2 days before merging so that people have time to look and test the code. |
Okay, so this merge wasn't the cleanest one and we had issue reports that melpa compiled version did not load.
@sergv: Can you inline the |
The |
@gracjan I'll inline the macro and add prefixes, stay tuned! |
@gracjan why are macros not a good thing? The |
Macros are another layer of abstraction that a potential contributor needs to understand. As such it poses a possible mental roadblock which we would rather like to avoid. |
Fair enough |
This is a wrapper around haskell-mode, that mostly adds fontification for {#...#} blocks.