Warn about packages default value in docs #8300
Conversation
jneira
changed the title
There was a problem hiding this comment.
Clear improvement, thank you!
one thing I can’t stop thinking about though is why not change the implementation such that the old docs were true, meaning not require packages. The default value makes a lot of sense, so why not use it even if cabal.project is present.
|
Yeah, in the issue the empty default value when project file is present was defended but there are no concrete arguments. Weird semantics, if you would ask me. |
|
This probably should be backported… Is there a [skip ci] policy on Cabal repository? I always forget to put personally, but it can speed up the merge tremendously. Also, Not sure if Mergify supports it out of the box. GitHub itself does. |
|
@mergify backport 3.8 |
🟠 Waiting for conditions to match
|
|
That's a lot of approvals. Shall we merge? |
|
@jneira is busy, so let me trigger the process. |
|
@mergify backport 3.8 |
🟠 Waiting for conditions to match
|
* Warn about packages default value * Use double backquotes * Syntax correction Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 180b671)
✅ Backports have been created
|
Warn about packages default value in docs (backport #8300)
packagesis defined #5850Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!