Implement +nowrap verbosity flag to suppress log-msg line-wrapping #4091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, propagating the `Verbosity` to the `topHandler` proves to be more complicated. This is mostly a problem for `die` invocations which are translated into user-error exceptions (which in turn then cause callstacks to be printed; are we abusing `die`?)
|
I guess reworking just dieMsg for now is OK. LGTM. |
|
@ezyang btw, the confusing part about |
|
We should rename it then, to e.g. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, propagating the
Verbosityto thetopHandlerproves to be more complicated.
This is mostly a problem for
dieinvocations which are translatedinto user-error exceptions (which in turn then cause callstacks
to be printed; are we abusing
die?)