Add disjoint
#559
Add disjoint
#559
Conversation
...to improve the readability of the generated code.
| disjointSubtrees _s _a Empty = True | ||
| disjointSubtrees s a (Leaf hB (L kB _)) = | ||
| lookupCont (\_ -> True) (\_ _ -> False) hB kB s a | ||
| disjointSubtrees s a b@Collision{} = disjointSubtrees s b a |
There was a problem hiding this comment.
Unfortunately GHC fails to specialize this and we end up with stuff like
disjoint_$s$wdisjointSubtrees @a @b @Int bx bx1 ww $fEqInt wild
or
disjoint_$s$wdisjointSubtrees @a @b @String bx bx1 ww $fEqList_$s$fEqList1 wild
There was a problem hiding this comment.
I misunderstood.
This function seems to be the result of case liberation (EDIT: it's not, it's due to -fspec-constr):
disjoint_$s$wdisjointSubtrees [Occ=LoopBreaker]
:: forall b a k.
Word#
-> SmallArray# (Leaf k a) -> Int# -> Eq k => HashMap k b -> Bool
and I suspect the specialization failure is related to the Eq dict being tucked in the middle of the other parameters instead of being first.
There was a problem hiding this comment.
I can replicate the issue with -O1 -fspec-constr.
There was a problem hiding this comment.
I have made a GHC issue: https://gitlab.haskell.org/ghc/ghc/-/issues/26615
| -- Note that as of GHC 9.12, SpecConstr creates a specialized worker for | ||
| -- handling the Collision vs. {BitmapIndexed,Full} and vice-versa cases, | ||
| -- but this worker fails to be properly specialized for different key | ||
| -- types. See https://gitlab.haskell.org/ghc/ghc/-/issues/26615. |
There was a problem hiding this comment.
Should we perform constructor specialization manually to work around this?
There was a problem hiding this comment.
I don't mind if you or someone else wants to work on this, but I won't.
2 participants
No description provided.