Fix acceptance/integration tests with modal non being closed #30806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
didoo
changed the title
didoo
force-pushed
the
hds/fix-modal-tests
branch
from
251522c to
09fb3cb
Compare
|
CI Results: |
|
Build Results: |
didoo
commented
Jun 2, 2025
didoo
commented
Jun 2, 2025
didoo
force-pushed
the
hds/fix-modal-tests
branch
from
09fb3cb to
3d6a27e
Compare
didoo
added
hashicorp-contributed-pr
Collaborator
Author
|
@Monkeychip can you have a look at this PR now? (and think about this comment, what is best to do: #30806 (comment)) Also, not sure why the check on |
didoo
added
hashicorp-contributed-pr
didoo
force-pushed
the
hds/fix-modal-tests
branch
2 times, most recently
from
0bb627a to
cf2beac
Compare
didoo
force-pushed
the
hds/fix-modal-tests
branch
from
cf2beac to
2049a07
Compare
lane-wetmore
approved these changes
Jun 17, 2025
Contributor
There was a problem hiding this comment.
Based on this discussion, this was the agreed upon solution which I also support.
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
…rp#30806) * added explicit actions to close modals in acceptance/integration tests * updated selector per recent buttons selectors refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
While smoke testing the adoption of HDS 4.20 (see hashicorp/design-system#2922) we noticed that two tests were failing. The reason for the failure is that now the content outside the modal is made
inertwhich means interaction with it are not possible until the modal is manually closed.This PR adds forced closure for the modals.
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-4908
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.