Skip to content

Conversation

@guygrigsby
Copy link
Member

@guygrigsby guygrigsby commented May 20, 2025

Description

working fix for VAULT-35109

this should change our reporting numbers for duplicates as well. The reporting will only include those that are actual duplicates rather that existing entities that are being updated or new entities. Need to determine if this change will cause any alarm bells to go off before merging.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@guygrigsby guygrigsby added this to the 1.20.0-rc milestone May 20, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 20, 2025
@guygrigsby guygrigsby added pr/no-changelog and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels May 20, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 20, 2025
@github-actions
Copy link

github-actions bot commented May 20, 2025

CI Results:
All Go tests succeeded! ✅

@guygrigsby guygrigsby changed the title reduce unnesessary logging when checking for entity alias merging reduce unnecessary logging when checking for entity alias merging May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant