[VAULT-34742] UI: move the generic select block in FormField under the HDS block

[didoo]

Description

What does this PR do?

• updated logic in isHdsFormField of FormField to include the generic select use case
• moved template logic for generic select in FormField under the isHdsField block

Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34742

Diffs

A few examples of before vs after:

Before:

After:

---

Before:

After:

👉 In this case the @helpText instead of being hidden behind a tooltip, is exposed as field's helper text (better for accessibility)

TODO only if you're a HashiCorp employee

• Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
  • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
• ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
  of a public function, even if that change is in a CE file, double check that
  applying the patch for this PR to the ENT repo and running tests doesn't
  break any tests. Sometimes ENT only tests rely on public functions in CE
  files.
• Jira: If this change has an associated Jira, it's referenced either
  in the PR description, commit message, or branch name.
• RFC: If this change has an associated RFC, please link it in the description.
• ENT PR: If this change has an associated ENT PR, please link it in the
  description. Also, make sure the changelog is in this PR, not in your ENT PR.

[github-actions]

CI Results:
All Go tests succeeded! ✅

[github-actions]

Build Results:
All builds succeeded! ✅

[Monkeychip]

Looks great. Left some comments but one is more for me, and the other is for when you move to checkboxes.

[didoo]

Looks great. Left some comments but one is more for me, and the other is for when you move to checkboxes.

@Monkeychip I replied to both :)