Skip to content

Conversation

@didoo
Copy link
Collaborator

@didoo didoo commented Mar 18, 2025

Description

What does this PR do?

  • replaces the internal implementation of FilterInput with the equivalent Hds::Form::TextInput::Base
    • in the process we have removed the <div class="control> wrapper (not needed anymore)

Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34703

Screenshots:
screenshot_4800

🕹️ Video: https://github.com/user-attachments/assets/0d7d76d2-640d-473d-904a-568bcc3a8ae5

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@didoo didoo requested a review from a team as a code owner March 18, 2025 09:06
@didoo didoo force-pushed the VAULT-34671/update-inputsearch-component_VAULT-34703 branch from 5a658f6 to 14efbc6 Compare March 18, 2025 09:07
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 18, 2025
@didoo didoo added this to the 1.20.0-rc milestone Mar 18, 2025
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented Mar 18, 2025

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note: We have been slowly adding generic selectors to our tests/helpers/general-selectors.ts file, where this specific selector now exists. This file however, is old enough we don't import it. In the future if you run into a selector change, check if the test file imports import { GENERAL } from 'vault/tests/helpers/general-selectors';. If it does then you could do something like GENERAL.inputSearch('search-input-role'). Again, not something to change here, but more a note for the future.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duly noted :) (as in TIL)

I've added a commit here: 5885bc0

Monkeychip
Monkeychip previously approved these changes Mar 18, 2025
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. For posterity, I smoked tested a couple of the fall back instances and ran enterprise tests locally.

Thanks again for the work and pr description!

@didoo didoo force-pushed the VAULT-34671/update-inputsearch-component_VAULT-34703 branch from 5885bc0 to 45a3112 Compare March 18, 2025 19:51
@didoo didoo requested a review from Monkeychip March 18, 2025 19:51
@didoo didoo merged commit 0c940f8 into main Mar 18, 2025
33 checks passed
@didoo didoo deleted the VAULT-34671/update-inputsearch-component_VAULT-34703 branch March 18, 2025 20:40
hellobontempo pushed a commit that referenced this pull request May 21, 2025
…extInput` (#29949)

* [UI] replaced internal implementation of `InputSearch` with equivalent `Hds::Form::TextInput::Base` (#34703)

* [UI] fixed acceptance test for `InputSearch` (#34703)

* [UI] updated selector in acceptance test for `InputSearch` (#34703)

per PR suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed hds-service HDS Service pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants