-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[VAULT-34703] UI: update InputSearch component to use Hds::Form::TextInput
#29949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VAULT-34703] UI: update InputSearch component to use Hds::Form::TextInput
#29949
Conversation
5a658f6 to
14efbc6
Compare
|
Build Results: |
|
CI Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note: We have been slowly adding generic selectors to our tests/helpers/general-selectors.ts file, where this specific selector now exists. This file however, is old enough we don't import it. In the future if you run into a selector change, check if the test file imports import { GENERAL } from 'vault/tests/helpers/general-selectors';. If it does then you could do something like GENERAL.inputSearch('search-input-role'). Again, not something to change here, but more a note for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duly noted :) (as in TIL)
I've added a commit here: 5885bc0
Monkeychip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. For posterity, I smoked tested a couple of the fall back instances and ran enterprise tests locally.
Thanks again for the work and pr description!
…t `Hds::Form::TextInput::Base` (#34703)
per PR suggestion
5885bc0 to
45a3112
Compare
…extInput` (#29949) * [UI] replaced internal implementation of `InputSearch` with equivalent `Hds::Form::TextInput::Base` (#34703) * [UI] fixed acceptance test for `InputSearch` (#34703) * [UI] updated selector in acceptance test for `InputSearch` (#34703) per PR suggestion
Description
What does this PR do?
<div class="control>wrapper (not needed anymore)Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34703
Screenshots:

🕹️ Video: https://github.com/user-attachments/assets/0d7d76d2-640d-473d-904a-568bcc3a8ae5
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.