-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[VAULT-34704] UI: update FilterInput component to use Hds::Form::TextInput
#29946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VAULT-34704] UI: update FilterInput component to use Hds::Form::TextInput
#29946
Conversation
|
CI Results: |
af5df7b to
58d6055
Compare
58d6055 to
b6b8c83
Compare
|
Build Results: |
b6b8c83 to
fa8b478
Compare
…t `Hds::Form::TextInput::Base` (#34704)
…nput::Base` arguments/API (#34704) sq2
fa8b478 to
38c24e6
Compare
| {{/if}} | ||
| <FilterInput | ||
| id={{this.inputId}} | ||
| @id={{this.inputId}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to blow out the scope of this PR but it seems like this can be removed (and here) since the input self-generates an id
hellobontempo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some non-blocking questions, I'm mostly wondering if we can do some additional cleanup and remove redundant @id args.
@hellobontempo I am worried that removing @Monkeychip maybe you can collect these cases in your follow-up cleanup epic? |
☝️ ➕ ➕ That sounds good to me! It's fairly clear to me that it's not needed anymore, but I agree it makes the most sense to tackle as follow-on cleanup. This form component swap is a lot as it is and keeping the scope narrow is important. |
…extInput` (#29946) * [UI] replaced internal implementation of `FilterInput` with equivalent `Hds::Form::TextInput::Base` (#34704) * [UI] updated `FilterInput` instances to use correct `Hds::Form::TextInput::Base` arguments/API (#34704) * [UI] updated `FilterInput` integration tests (#34704)
Description
What does this PR do?
FilterInputwith the equivalentHds::Form::TextInput::Base<div class="control >wrapper (not needed anymore)FilterInputinstances to use the correctHds::Form::TextInput::Basearguments/APIFilterInputcomponentJira ticket: https://hashicorp.atlassian.net/browse/VAULT-34704
A few video recordings of the updates UIs:
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.