Skip to content

Conversation

@didoo
Copy link
Collaborator

@didoo didoo commented Mar 17, 2025

Description

What does this PR do?

  • replaces the internal implementation of FilterInput with the equivalent Hds::Form::TextInput::Base
    • in the process we have made a few structural changes:
      • removed the <div class="control > wrapper (not needed anymore)
      • removed the autofocus feature (has negative accessibility implications, see thread)
  • updated all the existing FilterInput instances to use the correct Hds::Form::TextInput::Base arguments/API
  • updated the integration tests for the FilterInput component

Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34704

A few video recordings of the updates UIs:

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@didoo didoo added this to the 1.20.0-rc milestone Mar 17, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 17, 2025
@github-actions
Copy link

github-actions bot commented Mar 17, 2025

CI Results:
All Go tests succeeded! ✅

@didoo didoo force-pushed the VAULT-34671/update-filterinput-component_VAULT-34704 branch from af5df7b to 58d6055 Compare March 18, 2025 00:01
@didoo didoo marked this pull request as ready for review March 18, 2025 07:53
@didoo didoo requested a review from a team as a code owner March 18, 2025 07:53
@didoo didoo force-pushed the VAULT-34671/update-filterinput-component_VAULT-34704 branch from 58d6055 to b6b8c83 Compare March 18, 2025 07:53
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

Build Results:
All builds succeeded! ✅

@didoo didoo force-pushed the VAULT-34671/update-filterinput-component_VAULT-34704 branch from b6b8c83 to fa8b478 Compare March 19, 2025 12:06
@didoo didoo requested a review from Monkeychip March 19, 2025 12:07
@didoo didoo force-pushed the VAULT-34671/update-filterinput-component_VAULT-34704 branch from fa8b478 to 38c24e6 Compare March 19, 2025 17:52
{{/if}}
<FilterInput
id={{this.inputId}}
@id={{this.inputId}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to blow out the scope of this PR but it seems like this can be removed (and here) since the input self-generates an id

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some non-blocking questions, I'm mostly wondering if we can do some additional cleanup and remove redundant @id args.

@didoo
Copy link
Collaborator Author

didoo commented Mar 19, 2025

Looks good! Just some non-blocking questions, I'm mostly wondering if we can do some additional cleanup and remove redundant @id args.

@hellobontempo I am worried that removing @ids without knowing if they're used in other parts of the codebase could break something. And checking if they are used or not may not be trivial (for me at least). So I prefer to keep the "logic" as is, unless it's clear that something is not used/needed anymore.

@Monkeychip maybe you can collect these cases in your follow-up cleanup epic?

@hellobontempo
Copy link
Contributor

Looks good! Just some non-blocking questions, I'm mostly wondering if we can do some additional cleanup and remove redundant @id args.

@hellobontempo I am worried that removing @ids without knowing if they're used in other parts of the codebase could break something. And checking if they are used or not may not be trivial (for me at least). So I prefer to keep the "logic" as is, unless it's clear that something is not used/needed anymore.

@Monkeychip maybe you can collect these cases in your follow-up cleanup epic?

☝️ ➕ ➕ That sounds good to me! It's fairly clear to me that it's not needed anymore, but I agree it makes the most sense to tackle as follow-on cleanup. This form component swap is a lot as it is and keeping the scope narrow is important.

@didoo didoo merged commit 2679c42 into main Mar 19, 2025
33 checks passed
@didoo didoo deleted the VAULT-34671/update-filterinput-component_VAULT-34704 branch March 19, 2025 20:06
hellobontempo pushed a commit that referenced this pull request May 21, 2025
…extInput` (#29946)

* [UI] replaced internal implementation of `FilterInput` with equivalent `Hds::Form::TextInput::Base` (#34704)

* [UI] updated `FilterInput` instances to use correct `Hds::Form::TextInput::Base` arguments/API (#34704)

* [UI] updated `FilterInput` integration tests (#34704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed hds-service HDS Service pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants