Skip to content

Conversation

@zofskeez
Copy link
Contributor

Description

At some point in the recent past, an update to Chrome(Mac) has caused tests to fail locally when running in headless mode. Specifically, on HDS modal dismiss the attached listener on the close event is not triggering which results in a pending test waiter that causes a timeout. Interestingly enough, this is not an issue with the linux version of Chrome as witnessed in passing CI runs and on my local linux machine.

This PR updates the start-vault script to conditionally add the --launch flag to the testing command that will run the tests in headless Firefox instead when the environment is not CI and the server flag is not present.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@zofskeez zofskeez requested a review from a team as a code owner March 17, 2025 22:54
@zofskeez zofskeez added this to the 1.20.0-rc milestone Mar 17, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 17, 2025
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@zofskeez zofskeez merged commit 173c3fe into main Mar 19, 2025
42 of 45 checks passed
@zofskeez zofskeez deleted the ui/local-testing-fix branch March 19, 2025 17:53
@Monkeychip Monkeychip mentioned this pull request May 5, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants