[VAULT-34728] UI: prepare FormField template logic for migration to HDS components

[didoo]

Description

What does this PR do?

This PR lays the groundwork for migrating (one by one) the different input types handled within the FormField component to their equivalent HDS components (eg. we will start with textarea, password, generic select, generic input, etc)

For now the PR doesn't contain actual code migration, there are just placeholder comments. If you want to have an idea of what the migrated code would look like (approximately) have a look at this explorations/spike that I did, that led to this "official" PR: https://github.com/hashicorp/vault/pull/29943/files

The goal of this PR is to validate the approach with the Vault UI Engineers and see if this is a direction they approve, gather their feedback, and have them do a code review to see if things could be done in a different way.

Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34728

TODO only if you're a HashiCorp employee

• Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
  • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
• ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
  of a public function, even if that change is in a CE file, double check that
  applying the patch for this PR to the ENT repo and running tests doesn't
  break any tests. Sometimes ENT only tests rely on public functions in CE
  files.
• Jira: If this change has an associated Jira, it's referenced either
  in the PR description, commit message, or branch name.
• RFC: If this change has an associated RFC, please link it in the description.
• ENT PR: If this change has an associated ENT PR, please link it in the
  description. Also, make sure the changelog is in this PR, not in your ENT PR.

[didoo]

There is a lot of code change here, but I've just nested the existing code under the {{else}} condition (which changed the code indentation)

[hellobontempo]

Thanks for the note! I often suggest folks review with "hide whitespace" if there's a code change like this

[github-actions]

Build Results:
All builds succeeded! ✅

[didoo]

This whole conditional logic will be little by little populated, depending on the component that are migrated to HDS. If you want to see an example have a look at this similar (spike) PR:

vault/ui/lib/core/addon/components/form-field.js

Lines 90 to 106 in 21a890a

	get isHdsFormField() {
	const { type, options } = this.args.attr;
	// here we replicate the logic in the template, to make sure we don't change the order in which the "ifs" are evaluated
	if (options?.possibleValues?.length > 0) {
	// for now we leave these fields as they are
	return false;
	} else {
	// converted to HDS fields
	if ((type === 'number' || type === 'string') && options?.editType === 'password') {
	return true;
	} else {
	// everything is the same as before
	return false;
	}
	}
	}

[hellobontempo]

I desperately want to clean the template logic up, but I think this approach makes sense to streamline adoption and narrow the scope of this work as much as possible!

[github-actions]

CI Results:
All Go tests succeeded! ✅

[zofskeez]

This makes good sense to me and I appreciate the incremental approach 🎉

[hellobontempo]

I think this makes sense! I'm curious about the logic flow for displaying the actual HDS components, but this seems like a great way to tackle this work as non-invasively as possible.