Skip to content

Conversation

@didoo
Copy link
Collaborator

@didoo didoo commented Mar 17, 2025

Description

What does this PR do?

  • replace generic <input> in NavigateInput component with equivalent Hds::Form::TextInput::Base

Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34702

Before:
screenshot_4784
🕹️ Video: https://github.com/user-attachments/assets/c346d585-8dad-414a-ae7e-63fcfe9622a9

After:
screenshot_4783
🕹️ Video: https://github.com/user-attachments/assets/3e11ec51-5e6d-4bb4-ba09-c558379fdabe

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

…ivalent `Hds::Form::TextInput::Base` (#34702)
@didoo didoo added this to the 1.20.0-rc milestone Mar 17, 2025
@didoo didoo requested a review from Monkeychip March 17, 2025 12:02
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 17, 2025
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@didoo didoo marked this pull request as ready for review March 17, 2025 12:26
@didoo didoo requested a review from a team as a code owner March 17, 2025 12:26
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thank you for the video and before and after screenshots. I smoke tested and double checked that nested paths (e.g. beep/bop/boop) secret paths work.

@didoo didoo merged commit 730119b into main Mar 17, 2025
72 checks passed
@didoo didoo deleted the VAULT-34671/update-navigateinput-component_VAULT-34702 branch March 17, 2025 17:15
hellobontempo pushed a commit that referenced this pull request May 21, 2025
…ivalent `Hds::Form::TextInput::Base` (#34702) (#29941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed hds-service HDS Service pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants