Skip to content

Conversation

@didoo
Copy link
Collaborator

@didoo didoo commented Mar 17, 2025

Description

What does this PR do?

  • replaced InputSearch instance with Hds::Form::TextInput::Base
    • Notice:
      • I have changed the color of the button from secondary to primary (more in line with the HDS guidance, being the primary action in that context)
      • we may want to add a label to the field (and use Hds::Form::TextInput::Field instead), but it's a decision for the Vault Engineers/Designers + @MelSumner)
  • completely removed the InputSearch component (not used/needed anymore)

Before:
screenshot_4781
🕹️ Video: https://github.com/user-attachments/assets/7c7e8c87-4724-4e8f-bc5c-dde55f869818

After:
screenshot_4782
🕹️ Video: https://github.com/user-attachments/assets/03c466db-9f0a-4f9a-ab9f-56baa7be42db

Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34703

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

didoo added 2 commits March 17, 2025 10:18
…` (#34703)

(we may later decide to add a label, but I have to speak first with Vault engineers and Melanie)
@didoo didoo requested a review from Monkeychip March 17, 2025 10:54
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 17, 2025
@didoo didoo added this to the 1.20.0-rc milestone Mar 17, 2025
<Hds::Button
@text={{this.buttonText}}
@color="secondary"
@color="primary"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the color of the button from secondary to primary (more in line with the HDS guidance, being the primary action in that context)

data-test-view-secret
/>
<div class="field">
<Hds::Form::TextInput::Base
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This input is missing a label, which is a problem from an accessibility standpoint. Some options we may have to fix this:

  • convert the Hds::Form::TextInput::Base to Hds::Form::TextInput::Field and add a visible label (in which case, who should I speak to in order to know which text label to use? @Monkeychip do I need to speak with a Vault designer or you can provide one that I can use?)
  • add some aria label or an invisible label (but I am not sure what would be the benefit, in this case, ti hide the label)

@MelSumner other suggestions or thoughts?

@github-actions
Copy link

CI Results: failed ❌

@didoo
Copy link
Collaborator Author

didoo commented Mar 17, 2025

Closing this PR because I've missed that the component was used with "old" Ember code instantiation ({{component @fellbackComponent}}) - See comment here: https://hashicorp.atlassian.net/browse/VAULT-34703?focusedCommentId=682298

@didoo didoo closed this Mar 17, 2025
@didoo didoo changed the title [VAULT-34671] UI: Remove InputSearch component and replace with Hds::Form::TextInput [VAULT-34673] UI: Remove InputSearch component and replace with Hds::Form::TextInput Mar 17, 2025
@didoo didoo changed the title [VAULT-34673] UI: Remove InputSearch component and replace with Hds::Form::TextInput [VAULT-34703] UI: Remove InputSearch component and replace with Hds::Form::TextInput Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed hds-service HDS Service pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant