-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[VAULT-34703] UI: Remove InputSearch component and replace with Hds::Form::TextInput
#29940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…` (#34703) (we may later decide to add a label, but I have to speak first with Vault engineers and Melanie)
| <Hds::Button | ||
| @text={{this.buttonText}} | ||
| @color="secondary" | ||
| @color="primary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the color of the button from secondary to primary (more in line with the HDS guidance, being the primary action in that context)
| data-test-view-secret | ||
| /> | ||
| <div class="field"> | ||
| <Hds::Form::TextInput::Base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This input is missing a label, which is a problem from an accessibility standpoint. Some options we may have to fix this:
- convert the
Hds::Form::TextInput::BasetoHds::Form::TextInput::Fieldand add a visible label (in which case, who should I speak to in order to know which text label to use? @Monkeychip do I need to speak with a Vault designer or you can provide one that I can use?) - add some aria label or an invisible label (but I am not sure what would be the benefit, in this case, ti hide the label)
@MelSumner other suggestions or thoughts?
|
CI Results: failed ❌ |
|
Closing this PR because I've missed that the component was used with "old" Ember code instantiation ( |
InputSearch component and replace with Hds::Form::TextInputInputSearch component and replace with Hds::Form::TextInput
InputSearch component and replace with Hds::Form::TextInputInputSearch component and replace with Hds::Form::TextInput
Description
What does this PR do?
InputSearchinstance withHds::Form::TextInput::Basesecondarytoprimary(more in line with the HDS guidance, being the primary action in that context)Hds::Form::TextInput::Fieldinstead), but it's a decision for the Vault Engineers/Designers + @MelSumner)InputSearchcomponent (not used/needed anymore)Before:

🕹️ Video: https://github.com/user-attachments/assets/7c7e8c87-4724-4e8f-bc5c-dde55f869818
After:

🕹️ Video: https://github.com/user-attachments/assets/03c466db-9f0a-4f9a-ab9f-56baa7be42db
Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34703
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.