Skip to content

[Chore] - Remove unneeded string extensions #29834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

emoncuso
Copy link
Contributor

@emoncuso emoncuso commented Mar 5, 2025

Description

This PR removes an unneeded polyfill for String.includes (compat table)

It also removes some unneeded string dependencies from the package.json

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 5, 2025
@emoncuso emoncuso changed the title Chore/remote string includes polyfill [Chore] - Remove unneeded string extensions Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the meat of the change. Removing the includes extension as it's baked into JS now.

@emoncuso emoncuso marked this pull request as ready for review March 5, 2025 19:29
@emoncuso emoncuso requested review from a team as code owners March 5, 2025 19:29
@emoncuso emoncuso requested a review from tcrayford March 5, 2025 19:29
Copy link

github-actions bot commented Mar 5, 2025

Build Results:
All builds succeeded! ✅

@Monkeychip Monkeychip added the ui label Mar 5, 2025
@Monkeychip Monkeychip added this to the 1.20.0-rc milestone Mar 5, 2025
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 note: smoke tested and enterprise test passed for me locally.

@emoncuso emoncuso added backport/1.18.x backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent and removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Mar 5, 2025
@emoncuso emoncuso merged commit 2c94c00 into main Mar 5, 2025
61 of 63 checks passed
@emoncuso emoncuso deleted the chore/remote-string-includes-polyfill branch March 5, 2025 22:35
hellobontempo pushed a commit that referenced this pull request May 21, 2025
* remove usage of string includes polyfill

* remove deps as well

* add changelog entry

* add .gitkeep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.19.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants