Skip to content

Conversation

@drivera258
Copy link
Contributor

@drivera258 drivera258 commented Feb 13, 2025

Description

What does this PR do?

Adds input field for 'skip_import_rotation' for static roles on the database role creation page

Making static roles with and without skip:

Screen.Recording.2025-02-14.at.3.25.35.PM.mov

Sample read for staticuser2 that skipped initial rotation:

image

Trying to edit static role:

Screen.Recording.2025-02-14.at.3.35.45.PM.mov

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 13, 2025
@drivera258 drivera258 changed the title UI: adding skip import rotation field to ui UI: adding skip import rotation field when creating static roles Feb 13, 2025
@github-actions
Copy link

github-actions bot commented Feb 13, 2025

CI Results:
All Go tests succeeded! ✅

@drivera258 drivera258 added this to the 1.19.0-rc milestone Feb 14, 2025
@tomcf-hcp tomcf-hcp modified the milestones: 1.19.0-rc, 1.19.1 Feb 18, 2025
@drivera258 drivera258 marked this pull request as ready for review February 19, 2025 19:59
@drivera258 drivera258 requested review from a team as code owners February 19, 2025 19:59
@drivera258 drivera258 requested a review from tom-pang February 19, 2025 19:59
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@drivera258 drivera258 added the ui label Feb 19, 2025
@drivera258 drivera258 modified the milestones: 1.19.1, 1.20.0-rc Feb 19, 2025
@drivera258 drivera258 removed the request for review from tom-pang February 19, 2025 21:41
@drivera258 drivera258 merged commit dd8a0d5 into main Feb 19, 2025
62 checks passed
@drivera258 drivera258 deleted the ui/VAULT-33862/add-static-skip branch February 19, 2025 23:49
hellobontempo pushed a commit that referenced this pull request May 21, 2025
)

* adding skip import rotation field to ui

* changing labels and subtext

* removing readonly, user input on edit would not affect value

* changelog

* fix test

* fix test2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants