Skip to content

[Storage/DynamoDB] Let vault modify dynamodb tables #29371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025
Merged

[Storage/DynamoDB] Let vault modify dynamodb tables #29371

merged 3 commits into from
Jan 21, 2025

Conversation

michael-diggin
Copy link
Contributor

@michael-diggin michael-diggin commented Jan 20, 2025

Description

Fixes Issue #25114.

This PR introduces support for creating the DynamoDB table that Vault would use with PAY_PER_REQUEST billing mode, and introduces support for allowing Vault to modify the billing mode and read/write capacity of the table if it already exists. This is done with new environment variables, and the current default behaviour is left unchanged (no-ops if the table already exists).

cc @schavis, @VioletHynes

@michael-diggin michael-diggin requested review from a team as code owners January 20, 2025 21:32
@michael-diggin
Copy link
Contributor Author

cc @VioletHynes here is the new PR :)

Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again :)

@michael-diggin
Copy link
Contributor Author

These failures don't seem related to my changes if I understand correctly.
eg failing to install docker in the GH action https://github.com/hashicorp/vault/actions/runs/12875984251/job/35898853797?pr=29371#step:13:58
or proto files being different https://github.com/hashicorp/vault/actions/runs/12875984241/job/35898823559?pr=29371#step:5:324
Is there anything I can do/change in my PR to fix these checks?

@VioletHynes
Copy link
Contributor

Yeah, I'm looking into the CI failures. They're unrelated to your changes and failing elsewhere too. I'll try and get it fixed then merge it into this branch. Appreciate your patience!

@michael-diggin
Copy link
Contributor Author

Ah no worries, thanks for looking into it!

@VioletHynes
Copy link
Contributor

Okay, CI issue fixed and everything's passing. I just need a re-review from the docs team, but this should be ready to go soon :)

@VioletHynes VioletHynes merged commit 5b4b606 into hashicorp:main Jan 21, 2025
69 of 70 checks passed
@michael-diggin
Copy link
Contributor Author

Ah amazing thank you for reviewing and seeing this through @VioletHynes!

@michael-diggin michael-diggin deleted the add-ability-to-modify-dynamo-tables branch January 22, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants