pass context to S3 and dynamoDB storage calls #27927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletHynes
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Hi there! I'm sorry this took some time to get eyes on. This looks good to me, and I'd be happy to merge it. The only thing that's missing to get this mergeable is a changelog for the PR.
This would be a file in the changelog directory called 27927.txt with a brief description of the change. It should be classified as an improvement and feel free to take inspiration from the examples within the folder.
|
Added the changelog. I'm not sure if having multiple lines in the same block is allowed so let me know if the format needs changing. |
VioletHynes
reviewed
Sep 20, 2024
VioletHynes
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Passes the request context to S3 and dynamoDB storage calls so they are cancelled when the request context is cancelled.
We have encountered instances where requests that have long been cancelled by the client are still processed by vault and result in increased storage requests. Passing the context will ensure these immediately return an error in this case so resources aren't wasted.