Skip to content

remove packer-plugin-check command #11317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2022
Merged

remove packer-plugin-check command #11317

merged 1 commit into from
Feb 26, 2022

Conversation

azr
Copy link
Contributor

@azr azr commented Oct 8, 2021

⚠️ To merge only once all plugins stop using this

@azr azr mentioned this pull request Oct 8, 2021
Merged
@nywilken nywilken modified the milestones: 1.8.0, 1.8.1 Oct 8, 2021
azr added a commit to hashicorp/packer-plugin-sdk that referenced this pull request Oct 11, 2021
@azr
add pkr plugin check cmd from packer core (#85)
fef2ec6 
This is simplified to not pull in core as a dep. The drawback is that we don't actually start plugins to verify that it works with Packer and has a ConfigSpec func. We do start a binary, though. But, I think this is fine since if a plugin implements describe then we can be pretty sure it uses the SDK's function and interfaces.

Related to hashicorp/packer#11317

closes hashicorp/packer#11309
@azr azr marked this pull request as ready for review February 10, 2022 10:16
@azr azr requested a review from a team as a code owner February 10, 2022 10:16
@azr
Copy link
Contributor Author

azr commented Feb 10, 2022

This should be good to merge !

@ChiefGhostZero0x1

This comment was marked as spam.

Sign in to view
ChiefGhostZero0x1
ChiefGhostZero0x1 approved these changes Feb 10, 2022
View reviewed changes
Copy link

@ChiefGhostZero0x1 ChiefGhostZero0x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge /test

@azr @nywilken
remove packer-plugin-check command
dbf3618 
⚠️ to merge only once all plugins stop using this
@nywilken nywilken force-pushed the azr/remove-pkr-plugin-check branch from 194dd3f to dbf3618 Compare February 26, 2022 18:01
@nywilken nywilken merged commit f2a36af into master Feb 26, 2022
@nywilken nywilken deleted the azr/remove-pkr-plugin-check branch February 26, 2022 18:02
@azr
Copy link
Contributor Author

azr commented Feb 28, 2022

Thanks !

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ChiefGhostZero0x1 ChiefGhostZero0x1 ChiefGhostZero0x1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@azr @ChiefGhostZero0x1 @nywilken