Skip to content

Fix initialization order in EtasBus #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix initialization order in EtasBus #1704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions can/interfaces/etas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ def __init__(
data_bitrate: int = 2000000,
**kwargs: Dict[str, any],
):
super().__init__(channel=channel, **kwargs)

self.receive_own_messages = receive_own_messages
self._can_protocol = can.CanProtocol.CAN_FD if fd else can.CanProtocol.CAN_20

Expand Down Expand Up @@ -119,6 +117,9 @@ def __init__(

self.channel_info = channel

# Super call must be after child init since super calls set_filters
super().__init__(channel=channel, **kwargs)

def _recv_internal(
self, timeout: Optional[float]
) -> Tuple[Optional[can.Message], bool]:
Expand Down