Skip to content

Can Player compatibility with interfaces that use additional configuration #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,7 @@ jobs:
pylint --rcfile=.pylintrc \
can/**.py \
can/io \
setup.py \
doc/conf.py \
scripts/**.py \
examples/**.py \
can/interfaces/socketcan

Expand Down
6 changes: 5 additions & 1 deletion can/io/mf4.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,11 @@ class MF4Reader(BinaryIOMessageReader):
The MF4Reader only supports MF4 files that were recorded with python-can.
"""

def __init__(self, file: Union[StringPathLike, BinaryIO]) -> None:
def __init__(
self,
file: Union[StringPathLike, BinaryIO],
**kwargs: Any,
) -> None:
"""
:param file: a path-like object or as file-like object to read from
If this is a file-like object, is has to be opened in
Expand Down
4 changes: 3 additions & 1 deletion can/io/trc.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import os
from datetime import datetime, timedelta, timezone
from enum import Enum
from typing import Callable, Dict, Generator, List, Optional, TextIO, Union
from typing import Any, Callable, Dict, Generator, List, Optional, TextIO, Union

from ..message import Message
from ..typechecking import StringPathLike
Expand Down Expand Up @@ -49,6 +49,7 @@ class TRCReader(TextIOMessageReader):
def __init__(
self,
file: Union[StringPathLike, TextIO],
**kwargs: Any,
) -> None:
"""
:param file: a path-like object or as file-like object to read from
Expand Down Expand Up @@ -265,6 +266,7 @@ def __init__(
self,
file: Union[StringPathLike, TextIO],
channel: int = 1,
**kwargs: Any,
) -> None:
"""
:param file: a path-like object or as file-like object to write to
Expand Down