Skip to content

feat: extend IXXAT backend to support CAN-FD #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

semcodech
Copy link
Contributor

Introduce CAN-FD support for IXXAT using C-API for CAN-FD vcinpl2.dll.

@mergify mergify bot requested a review from hardbyte September 10, 2021 12:59
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #1126 (5c8ab29) into develop (596f07d) will increase coverage by 0.08%.
The diff coverage is 70.45%.

@@             Coverage Diff             @@
##           develop    #1126      +/-   ##
===========================================
+ Coverage    70.48%   70.57%   +0.08%     
===========================================
  Files           79       79              
  Lines         7677     7751      +74     
===========================================
+ Hits          5411     5470      +59     
- Misses        2266     2281      +15     

@semcodech
Copy link
Contributor Author

TBD: Consider keeping the original implementation based on vcinpl.dll in order to remain backwards-compatible, and introduce IXXAT with vcinpl2 as a new interface?

@semcodech
Copy link
Contributor Author

This PR is obviously a duplicate of #1119, following the approach suggested by @zariiii9003 in #1119 (comment). Feel free to close this PR if not required. Thank you.

@semcodech semcodech changed the title WIP: feat: extend IXXAT backend to support CAN-FD feat: extend IXXAT backend to support CAN-FD Sep 11, 2021
@fjburgos fjburgos mentioned this pull request Sep 13, 2021
@semcodech
Copy link
Contributor Author

Will move forward with #1119

@semcodech semcodech closed this Sep 22, 2021
@hardbyte
Copy link
Owner

hardbyte commented Dec 5, 2021

Thanks @ausserlesh

MattWoodhead added a commit to MattWoodhead/python-can that referenced this pull request Jun 2, 2023
MattWoodhead added a commit to MattWoodhead/python-can that referenced this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants