Add setShow callback for external control #140
Merged
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add registerSetShow to ConfirmableProps for confirmable to register its setShow function - Add setShow to ConfirmationHandle in controls - Call setShow(false) in proceed/dismiss/cancel to immediately hide dialog - This allows external control (proceed/dismiss/cancel) to update the show state 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
registerSetShowtoConfirmablePropsfor confirmable to register its setShow functionsetShowtoConfirmationHandlein controlssetShow(false)inproceed/dismiss/cancelto immediately hide dialogBackground
When using
controls.proceed()or other external control functions, the dialog'sshowstate was not being updated because the state is managed insideconfirmable. This caused the dialog to remain visible untilunmountDelaycompleted.With this change, external control functions now update the
showstate immediately, providing a smoother user experience.Test plan
proceed()/dismiss()/cancel()🤖 Generated with Claude Code