Fix portal cleanup in domTree mounter #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use root.unmount() before removing wrapper from DOM - This ensures React portals (e.g., Bootstrap modals) are properly cleaned up - Add dismiss function documentation to External Control section 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
root.unmount()before removing wrapper from DOMdismissfunction documentation to External Control section in READMEBackground
When using UI libraries that render via React portals (like Bootstrap Modal), simply removing the wrapper element from DOM doesn't clean up the portal-rendered elements. Calling
root.unmount()ensures React properly cleans up all mounted components including portals.Test plan
🤖 Generated with Claude Code