Skip to content

Conversation

@Laoujin
Copy link
Contributor

@Laoujin Laoujin commented Jul 6, 2025

Fixed 2 links in the README to the docs website.

I just went ahead and clicked all links and found that the link to the independent performance benchmark mustache vs handlebars is down:
http://sorescode.com/2010/09/12/benchmarks.html
I was unable to find it anywhere else on the web.


Before creating a pull-request, please check https://github.com/handlebars-lang/handlebars.js/blob/master/CONTRIBUTING.md first.

Generally we like to see pull requests that

  • Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • Have good commit messages
  • Have tests
  • Have the typings (types/index.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
  • Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

@jaylinski jaylinski merged commit cc8574e into handlebars-lang:master Jul 7, 2025
7 checks passed
@jaylinski
Copy link
Member

Thank you!

@Laoujin
Copy link
Contributor Author

Laoujin commented Jul 7, 2025

@jaylinski : What do you want to do with the independent benchmarks that is currently down?

As I said, I couldn't really find anything else, nor could I find the blog post on his github account :(

If you'd merge it, I can create a new independent blog post 😀

@jaylinski
Copy link
Member

jaylinski commented Jul 7, 2025

@Laoujin If you create a blog post, I would link it in the readme, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants