Skip to content

Add support for configuring my preferences #7495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Jun 3, 2025

What type of PR is this?

/kind feature
/area core
/milestone 2.21.x

What this PR does / why we need it:

This PR adds support for configuring my preferences. Two user-scoped APIs are added:

  • GET /apis/uc.api.halo.run/v1alpha1/user-preferences/{group}
  • PUT /apis/uc.api.halo.run/v1alpha1/user-preferences/{group}

e.g.:

❯ http -a faker:openfaker http://localhost:8090/apis/uc.api.halo.run/v1alpha1/user-preferences/fake
HTTP/1.1 200 OK

null
❯ http -a faker:openfaker PUT http://localhost:8090/apis/uc.api.halo.run/v1alpha1/user-preferences/fake --json halo=awesome
HTTP/1.1 204 No Content
❯ http -a faker:openfaker http://localhost:8090/apis/uc.api.halo.run/v1alpha1/user-preferences/fake
HTTP/1.1 200 OK
{
    "halo": "awesome"
}

Does this PR introduce a user-facing change?

提供根据分组获取和更新用户预设的 API

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 3, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 3, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 3, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen June 3, 2025 10:33
@JohnNiang JohnNiang changed the title Add support for configuring my preferences WIP: Add support for configuring my preferences Jun 3, 2025
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2025
@JohnNiang JohnNiang force-pushed the feat/user-preference branch from a423862 to 3bed7e2 Compare June 3, 2025 16:00
@JohnNiang JohnNiang changed the title WIP: Add support for configuring my preferences Add support for configuring my preferences Jun 3, 2025
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 3, 2025
@JohnNiang JohnNiang force-pushed the feat/user-preference branch from 3bed7e2 to bb2f019 Compare June 3, 2025 16:07
ruibaby added 2 commits June 4, 2025 11:51
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Copy link

pkg-pr-new bot commented Jun 4, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7495

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7495

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7495

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7495

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7495

commit: 29170f6

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2025
Copy link

f2c-ci-robot bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
Copy link

sonarqubecloud bot commented Jun 4, 2025

@ruibaby ruibaby merged commit fb62c1a into main Jun 4, 2025
6 of 7 checks passed
@ruibaby ruibaby deleted the feat/user-preference branch June 4, 2025 03:55
@JohnNiang JohnNiang modified the milestones: 2.21.x, 2.21.0 Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants