Skip to content

fix: correct attachment selection state after new upload #7487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 30, 2025

What type of PR is this?

/area ui
/kind bug
/milestone 2.21.x

What this PR does / why we need it:

Fix correct attachment selection state after new upload.

Which issue(s) this PR fixes:

Fixes #7472

Does this PR introduce a user-facing change?

修复当有已选择附件时,上传新附件导致所选附件状态异常的问题。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 30, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone May 30, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label May 30, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen May 30, 2025 08:34
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label May 30, 2025
Copy link

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.34%. Comparing base (42c374d) to head (f00d51f).
Report is 24 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7487      +/-   ##
============================================
- Coverage     59.55%   59.34%   -0.22%     
+ Complexity     3812     3749      -63     
============================================
  Files           677      674       -3     
  Lines         23248    23006     -242     
  Branches       1500     1481      -19     
============================================
- Hits          13846    13652     -194     
+ Misses         8764     8723      -41     
+ Partials        638      631       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2025
Copy link

f2c-ci-robot bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 7162b8d into halo-dev:main May 30, 2025
9 checks passed
@JohnNiang JohnNiang modified the milestones: 2.21.x, 2.21.0 Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

选择附件时上传会导致UI卡住
2 participants