Skip to content

Set Java 21 as minimal version #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/milestone 2.21.x

What this PR does / why we need it:

This PR sets Java 21 as minimal version. After doing that, Halo can only run on Java 21 or newer version.

Fortunately, all plugins and themes won't be affected by the restriction.

https://docs.gradle.org/current/userguide/toolchains.html#sec:release-flag-toolchain

Which issue(s) this PR fixes:

Fixes #6867

Does this PR introduce a user-facing change?

[Action Required] 更新最低运行环境为 Java 21

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (04c27db) to head (cc2acc2).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7451   +/-   ##
=========================================
  Coverage     59.44%   59.44%           
  Complexity     4142     4142           
=========================================
  Files           701      701           
  Lines         24014    24014           
  Branches       1543     1543           
=========================================
  Hits          14274    14274           
  Misses         9078     9078           
  Partials        662      662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruibaby
Copy link
Member

ruibaby commented May 19, 2025

Is it possible to take advantage of Virtual Threads now?

@JohnNiang
Copy link
Member Author

Is it possible to take advantage of Virtual Threads now?

Already done in #7261.

@JohnNiang JohnNiang added area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. labels May 19, 2025
@JohnNiang JohnNiang added this to the 2.21.x milestone May 19, 2025
@ruibaby
Copy link
Member

ruibaby commented May 19, 2025

Shouldn’t this also be updated here?

Copy link

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

需要对应修改 https://github.com/halo-dev/docs 中开发文档的部分。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
Copy link

f2c-ci-robot bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 0c4be85 into halo-dev:main May 20, 2025
9 checks passed
@JohnNiang JohnNiang modified the milestones: 2.21.x, 2.21.0 May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to set Java 21 as minimal version
2 participants