Skip to content

Add support for querying users by email #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

liuyiwuqing
Copy link
Contributor

@liuyiwuqing liuyiwuqing commented May 16, 2025

What type of PR is this?

/kind improvement

What this PR does / why we need it:

Add spec.email query for user endpoint.

Which issue(s) this PR fixes:

Fixes #7432

Does this PR introduce a user-facing change?

用户搜索支持根据邮箱地址

@CLAassistant
Copy link

CLAassistant commented May 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 16, 2025
@JohnNiang JohnNiang changed the title feat(user): 增加通过邮箱搜索用户功能 Add support for querying users by email May 19, 2025
@JohnNiang
Copy link
Member

Thank you for your first contribution!

Please sign CLA first before getting merged. You can rerfer to #7441 (comment).

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (04c27db) to head (b4a00f4).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7441   +/-   ##
=========================================
  Coverage     59.44%   59.44%           
  Complexity     4142     4142           
=========================================
  Files           701      701           
  Lines         24014    24015    +1     
  Branches       1543     1543           
=========================================
+ Hits          14274    14275    +1     
  Misses         9078     9078           
  Partials        662      662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 19, 2025
@JohnNiang JohnNiang added this to the 2.21.x milestone May 19, 2025
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JohnNiang JohnNiang merged commit 1520188 into halo-dev:main May 19, 2025
8 of 9 checks passed
@JohnNiang JohnNiang modified the milestones: 2.21.x, 2.21.0 Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

用户列表 关键词搜索没有邮箱字段筛选
4 participants