-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Add shared events for listening user login and logout in plugins #7440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: 添加用户登录事件和相关处理逻辑 #### Which issue(s) this PR fixes: halo-dev#7436
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
============================================
- Coverage 59.51% 59.50% -0.02%
- Complexity 3803 3811 +8
============================================
Files 677 680 +3
Lines 23225 23266 +41
Branches 1496 1500 +4
============================================
+ Hits 13823 13844 +21
- Misses 8763 8783 +20
Partials 639 639 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution!
I left some comments below, please take some time to have a look.
-移除 UserLoginEvent 和 UserLogoutEvent 中的冗余状态字段- 更新 LoginHandlerEnhancerImpl 和 LogoutSecurityConfigurer 中的登录处理方法 - 修改 UserLoginOrLogoutProcessing 中的登录和登出方法,移除不必要的状态参数
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
docs(事件): 补充用户登录和登出事件文档 #497 |
What type of PR is this?
/kind improvement
What this PR does / why we need it:
This PR adds UserLoginEvent and UserLogoutEvent which are shared to plugins.
Which issue(s) this PR fixes:
Fixes #7436
Does this PR introduce a user-facing change?