Skip to content

Fix potential twice theme route handler invocations #7419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

  1. This PR removes duplicate invocations while resolving handler functions of theme.
  2. Throw NotFoundException while post was not found.

Which issue(s) this PR fixes:

Fixes #7409

Does this PR introduce a user-facing change?

修复访问不存在的分类或者文章页面时始终抛出异常的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels May 9, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone May 9, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen May 9, 2025 04:57
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 9, 2025
Copy link

sonarqubecloud bot commented May 9, 2025

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (60c2009) to head (d7c7b78).
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7419      +/-   ##
============================================
+ Coverage     57.18%   59.44%   +2.26%     
- Complexity     4066     4114      +48     
============================================
  Files           721      697      -24     
  Lines         24546    23948     -598     
  Branches       1612     1548      -64     
============================================
+ Hits          14036    14236     +200     
+ Misses         9882     9059     -823     
- Partials        628      653      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2025
Copy link

f2c-ci-robot bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 8a68a59 into halo-dev:main May 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

访问空路由时halo日志中出现error级别错误
2 participants