refactor: modify plugin class loading order to follow parent delegation mechanism #7258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7258 +/- ##
============================================
+ Coverage 56.99% 57.15% +0.16%
- Complexity 3999 4049 +50
============================================
Files 714 720 +6
Lines 24110 24429 +319
Branches 1585 1605 +20
============================================
+ Hits 13742 13963 +221
- Misses 9756 9846 +90
- Partials 612 620 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
JohnNiang
approved these changes
Mar 6, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
guqing
added a commit
to guqing/halo
that referenced
this pull request
Mar 13, 2025
…delegation mechanism (halo-dev#7258)" This reverts commit 1d8a25c.
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
…delegation mechanism (#7258)" (#7290) #### What type of PR is this? /kind cleanup #### What this PR does / why we need it: 撤回对插件类加载顺序的改动这可能导致破坏性更新 同时，不在考虑修改加载顺序问题，由于社区版和专业版引入的依赖不同插件无法以社区版为依赖基准保证功能在专业版也可用，举个例子： 1. 插件引入了 okhttp4 作为依赖，这可能是插件引入的依赖所附带的 2. 在社区版没有问题，插件开发者也是这么测试的 3. 但是在专业版中引入了 okhttp3 作为依赖，此时插件在专业版就不可用了因为插件依赖了 okhttp4 的功能 通过上述问题就导致了不可预知的问题 #### Does this PR introduce a user-facing change? ```release-note 撤回对插件类加载顺序的改动这可能导致破坏性更新 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x
What this PR does / why we need it:
修改插件类加载顺序遵循双亲委派机制，以避免插件需要手动排除冲突类的问题
此 PR 的动力是：
resources 下的资源文件加载顺序还是插件优先，避免与 halo 同名文件不加载的问题
进过测试，插件依赖功能以及其他插件的功能不受影响，建议 Reviewer 再测试一遍
Does this PR introduce a user-facing change?