Add SSESpecification option to CreateTable #189
Conversation
createtable.go
Outdated
| @@ -216,6 +217,18 @@ func (ct *CreateTable) Tag(key, value string) *CreateTable { | |||
| return ct | |||
| } | |||
|
|
|||
| // SSEEncryption specifies the server side encryption for this table. | |||
| // Encryption is disabled by default. The valid values for sseType are {AES256, KMS}. | |||
| func (ct *CreateTable) SSEEncryption(enabled bool, keyID, sseType string) *CreateTable { | |||
There was a problem hiding this comment.
Let's define a type for SSEType instead of taking any string.
Something like this:
Lines 3 to 12 in a59ef6b
A lot of constants in this library are named ThingCategory instead of CategoryThing which is less than ideal, if that makes any sense. So maybe naming constants for the SSE stuff should have SSE as a prefix like SSETypeAES256 and SSETypeKMS.
|
Thanks for the PR, I left one comment. If you take care of that then I'll merge this. |
|
Oh yeah, you might want to look at DescribeTable and add the relevant SSE stuff to that as well. |
|
Hey @guregu , thanks for the quick reply here! I've updated the PR to reflect your comments. Can you take another look and merge if you're happy with this state? Thanks again! |
|
@TigerToof looks great! Thank you! |
Add the option to set the SSESpecification field when creating a table.
AWS reference: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_SSESpecification.html