-
-
Notifications
You must be signed in to change notification settings - Fork 16
Feature choose language #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alonmar
wants to merge
14
commits into
guedesfelipe:main
Choose a base branch
from
alonmar:feature_choose_language
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1fc7e30
✨ Add command to choose the language of quotes
alonmar d96ad39
✨ Add function to get actual lenguage
alonmar 160440b
✅ Update test whit new command
alonmar aba6e1b
✅ Update parameter in function
alonmar f176cc7
✅ Update dir quotes
alonmar 70f87fb
✅ Update test for language
alonmar 1fb9a52
✅ Update dir quotes
63ade95
✅ Update read quotes
alonmar 13036fd
✨ Add function to get actual list of lenguage
alonmar 61866e1
✅ Update commond to to Choose lenguage
alonmar ba981e6
♻️ Refactor code
alonmar 047120c
🐛 Fix bug unexpected keyword argument
alonmar c2ac056
✨ Update command to choose the language of quotes
alonmar 01d98c2
✨ Update command to choose the language of quotes
alonmar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guedesfelipe i am reformat the code, the download part would go here, but i really don't have much idea how to query the current branch to be able to download the quotes, can you give me a hint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I will take a look at the code and help you with that as soon as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I was busy these days and I still haven't been able to make an example code, but I was thinking of doing the part of downloading the translated files like this:
https://github.com/Textualize/rich/blob/master/examples/downloader.py
Or with Requests library...