Skip to content

CXX should not be hardcoded to g++ #690

Closed
@abbec

Description

@abbec

When using nix to create a custom derivation on macOS for building protoc-gen-grpc-web I ran into an issue where the protobuf libraries in nixpkgs are compiled with clang and the Makefile inside javascript/net/grpc/web hardcodes CXX to g++.

It builds fine if CXX is set to clang++ so I would propose changing the Makefile line to read

CXX ?= g++
...

to default to g++ but still allow overrides.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions