grpc-js(-xds): Pick up proto-loader update #2732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Apr 30, 2024
This was referenced May 23, 2024
This was referenced Jun 2, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 18, 2024
This was referenced Jun 20, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up the proto-loader update in #2731 for both grpc-js and grpc-js-xds. I had to update the grpc-js-xds generated code because this change updates proto-loader from 0.6.x to 0.7.x.
The tests will fail for this PR because it depends on a package version that doesn't exist yet.