binder: Rationalize @ThreadSafe-ty of BinderTransport. #12130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use @BinderThread to document restrictions on methods and certain fields. - Make TransactionHandler non-public since only Android should call it. - Replace an unnecessary AtomicLong with a plain old long.
jdcormie
changed the title
shivaspeaks
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
I'll buy what you're saying, just the question to understand the intent of that change of synchronized block.
CC @ejona86
binder/src/main/java/io/grpc/binder/internal/BinderTransport.java
Outdated
Show resolved
Hide resolved
|
See http://fusion2/7329b6cc-a124-44d8-8428-66b2a0b3773b for flow control stress test run. Results are neutral: http://perfgate/analysis-results?run_key=5468791659429888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12047