compiler: generate blocking v2 unary calls that throw StatusException #12126
Conversation
| @@ -182,6 +182,23 @@ public static <ReqT, RespT> RespT blockingUnaryCall( | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Executes a unary call and blocks on the response, converting StatusRuntimeException to | |||
| * StatusException for consistency with other blocking call types. | |||
There was a problem hiding this comment.
Remove "for consistency with other blocking call types."
|
You have included the generated stubs in the commit for interop-testing but not for android-interop-testing which causes Android build to fail. |
|
I see. |
|
You can install Android sdk following these steps and then do a build with Android build enabled. If you run into OOM during the build then we can look into upgrading the cloudtop or using a custom Kokoro VM and work on that VM. |
If you get an OOM, it normally isn't really the machine you're on. You generally just need to tell Gradle to use more memory. I think I put |
| @@ -182,6 +182,23 @@ public static <ReqT, RespT> RespT blockingUnaryCall( | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Executes a unary call and blocks on the response, converting StatusRuntimeException | |||
There was a problem hiding this comment.
Converting the exceptions is an implementation detail. You can say it uses a checked exception, but don't say it is "converting"
Yes right, I have kept |
|
I don't know how to resolve this Android failure. Android build in local works just fine, there's no reason to fail. @kannanjgithub |
Note on API-breaking change:
This change modifies the blocking unary call behavior in v2 stubs to throw a checked StatusException instead of an unchecked StatusRuntimeException.
Existing code using v1 stubs will continue to behave as before — no changes are required for v1.
For users not ready to adopt the new behavior in v2, you may continue using code generated with v1 stub style until you’re ready to migrate.
Fixes #11937