GoogleC2P: remove dependency on metadata server for IPv6 node metadata #8550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8550 +/- ##
==========================================
- Coverage 82.00% 81.42% -0.58%
==========================================
Files 413 413
Lines 40523 40621 +98
==========================================
- Hits 33230 33075 -155
- Misses 5909 6067 +158
- Partials 1384 1479 +95
🚀 New features to boost your workflow:
|
apolcyn
changed the title
apolcyn
changed the title
apolcyn
changed the title
Contributor
Author
|
@dfawley I'm having some trouble getting the PR validation to pass `This PR must have a label starting with 'Type:'. I don't have permissions to set labels. Besides that, sending for review |
dfawley
approved these changes
Sep 5, 2025
xds/googledirectpath/googlec2p.go
Outdated
| } | ||
| if envconfig.NewPickFirstEnabled { | ||
| // Enable dualstack endpoints in TD. | ||
| // TODO(apolcyn): remove IPv6 metadata server queries entirely after old pick first is removed. |
Member
There was a problem hiding this comment.
If there isn't already one, could you please file an issue (internal or on github) to track this work? Thanks!
Contributor
Author
There was a problem hiding this comment.
Thanks for the review!
Done, filed #8561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reliance on metadata server since it's result is no longer needed, hardcode IPv6 support in node metadata instead.
Related c++ change: grpc/grpc#40571
Note we preserve prior behavior in case experiment
NewPickFirstEnabledis disabled, because our testing/qualification has not covered that being disabled.Related: internal issue b/407587619
RELEASE NOTES: n/a