Skip to content

[Before Release] UI Polishments #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 23, 2021
Merged

[Before Release] UI Polishments #144

merged 14 commits into from
Aug 23, 2021

Conversation

softmarshmallow
Copy link
Member

@softmarshmallow softmarshmallow commented Aug 23, 2021 •
edited
Loading

UI Polishing with live pingpong feedbacks

@vercel
Copy link

vercel bot commented Aug 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/grida/assistant/B7Yw8poT5KKjtDjgeHkT6hFYgvVf
✅ Preview: https://assistant-git-staging-grida.vercel.app

@softmarshmallow softmarshmallow changed the title UI Polishments [Before Release] UI Polishments Aug 23, 2021
@softmarshmallow
Copy link
Member Author

softmarshmallow commented Aug 23, 2021 •
edited
Loading

Icons loader - progress bar color & lr margin

Error

Intended design here

@softmarshmallow
Copy link
Member Author

  1. Wrong Left margin for code/preview footer button
  2. Button should be disabled if no code content available.
    image

@softmarshmallow
Copy link
Member Author

  • Wrong font family
    image

@softmarshmallow
Copy link
Member Author

softmarshmallow commented Aug 23, 2021 •
edited
Loading

  1. Signin page after-signin-view contains unreachable content (Make it responsible)

-> https://user-images.githubusercontent.com/16307013/130387168-c19c19ef-d581-4f9e-a06e-d5c3a57e0c36.mov

  1. wrong font fam
    image

@softmarshmallow softmarshmallow marked this pull request as ready for review August 23, 2021 06:19
@softmarshmallow softmarshmallow merged commit 4ac0048 into main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@softmarshmallow @You-J