Fix: scannerctl scan-config translator #2065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scannerctl crashes when there is no preferences in the src XML scan config
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Tehforsch
reviewed
Nov 12, 2025
rust/src/scannerctl/scan_config.rs
Outdated
| #[derive(Clone, Debug, Deserialize, PartialEq)] | ||
| struct ScanConfigPreferences { | ||
| preference: Vec<ScanConfigPreference>, | ||
| preference: Option<Vec<ScanConfigPreference>>, |
Contributor
There was a problem hiding this comment.
Is there a good reason we couldn't do
#[serde(default)]
preference: Vec<ScanConfigPreference>,instead? This would default to an empty vec which sounds better to me than using an option
github-actions
bot
added
patch_release
jjnicola
force-pushed
the
scannerctl-scanconfig
branch
from
ca116ce to
828753e
Compare
github-actions
bot
added
patch_release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix: scannerctl scan-config translator
SC-1498
Why:
scannerctl crashes when there is no preferences in the src XML scan config
How:
Checklist: