Add new rule EC31: Prefer lighter formats for image files #52
Conversation
salah-dev-inp
force-pushed
the
EC31-prefer-lighter-formats-for-image-file
branch
from
4a61b04 to
b69c5f3
Compare
| ### Changed | ||
|
|
||
| ### Deleted | ||
| ## [1.6.2] - 2024-05-30 |
There was a problem hiding this comment.
why do you add this section title ?
please remove it and let your new line added under "Unreleased" section
| import org.sonar.api.utils.log.Loggers; | ||
|
|
||
| @Rule(key = "EC31") | ||
| @DeprecatedRuleKey(repositoryKey = "greencodeinitiative-java", ruleKey = "EC31") |
| if (tree.is(Tree.Kind.STRING_LITERAL)) { | ||
| LiteralTree literalTree = (LiteralTree) tree; | ||
| String value = literalTree.value(); | ||
|
|
There was a problem hiding this comment.
her, you can "return" empty if your string length is not > 6 (because the minimum length is 7 for your image name is : "a.png"
thus no need to execute the next if and the next for of the algorithm, for nothing.
| public PreferLighterImageFormatsCheck(PreferLighterImageFormatsCheck checker) { | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
add a use case test with my review feedback above => no need to check if string length isn't > 6
|
This PR has been automatically marked as stale because it has no activity for 30 days. |
|
This PR has been automatically marked as stale because it has no activity for 30 days. |
2 participants
No description provided.