Resize

.github/workflows/os-compatibility-test.yaml

@@ -48,6 +48,22 @@ jobs:
       - name: Prepare workspace
         uses: ./.github/actions/prepare-workspace
 
+      - name: Determine Toolchain Versions and cache paths
+        run: |
+          echo NODE_VERSION=$(make -C build.assets print-node-version) >> $GITHUB_ENV
+          echo GOLANG_VERSION=$(make -C build.assets print-go-version | sed 's/^go//') >> $GITHUB_ENV
+          echo RUST_VERSION=$(make -C build.assets print-rust-version) >> $GITHUB_ENV
+          echo WASM_PACK_VERSION=$(make -C build.assets print-wasm-pack-version) >> $GITHUB_ENV
+          echo PKG_CONFIG_PATH="$(build.assets/build-fido2-macos.sh pkg_config_path)" >> $GITHUB_ENV
+
+      - name: Print versions
+        run: |
+          echo "make: $(make --version)"
+          echo "node: ${NODE_VERSION}"
+          echo "go: ${GOLANG_VERSION}"
+          echo "rust: ${RUST_VERSION}"
+          echo "wasm-pack: ${WASM_PACK_VERSION}"
+
       - name: Run make
         run: |
           make -j"$(nproc)" binaries

Cargo.toml

@@ -23,16 +23,17 @@ codegen-units = 1
 [workspace.dependencies]
 # Note: To use a local IronRDP repository as a crate (for example, ironrdp-cliprdr), define the dependency as follows:
 # ironrdp-cliprdr = { path = "/path/to/local/IronRDP/crates/ironrdp-cliprdr" }
-# This rev hash corresponds to https://github.com/Devolutions/IronRDP/pull/436. It is being merged while that PR is
-# still open in IronRDP in order to get these changes into a release, however it should be updated once that PR is
-# merged. In the meantime, no other IronRDP hash's (without these changes) should be used.
-ironrdp-cliprdr = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
-ironrdp-connector = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
-ironrdp-graphics = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
-ironrdp-pdu = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
-ironrdp-rdpdr = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
-ironrdp-rdpsnd = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
-ironrdp-session = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
-ironrdp-svc = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
-ironrdp-tls = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275", features = ["rustls"]}
-ironrdp-tokio = { git = "https://github.com/Devolutions/IronRDP", rev = "49dab7d8df4bd785bf17fce97ac02beaba0b0275" }
+# This rev hash is for testing purposes only. It should NOT be merged, and should be updated to IronRDP master once
+# https://github.com/Devolutions/IronRDP/pull/430 and https://github.com/Devolutions/IronRDP/pull/436 are merged.
+ironrdp-cliprdr = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-connector = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-displaycontrol = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-dvc = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-graphics = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-pdu = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-rdpdr = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-rdpsnd = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-session = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-svc = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }
+ironrdp-tls = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce", features = ["rustls"]}
+ironrdp-tokio = { git = "https://github.com/Devolutions/IronRDP", rev = "8793b165b4467062dd0df675054186316dcc6cce" }

lib/srv/desktop/rdp/rdpclient/Cargo.toml

@@ -21,6 +21,8 @@ ironrdp-rdpdr.workspace = true
 ironrdp-rdpsnd.workspace = true
 ironrdp-session.workspace = true
 ironrdp-svc.workspace = true
+ironrdp-dvc.workspace = true
+ironrdp-displaycontrol.workspace = true
 ironrdp-tls.workspace = true
 ironrdp-tokio.workspace = true
 iso7816 = "0.1.2"
@@ -36,6 +38,8 @@ tokio = { version = "1.37", features = ["full"] }
 tokio-boring = { git = "https://github.com/gravitational/boring", rev="605253d99d5e363e178bcf97e1d4622e33844cd5", optional = true }
 utf16string = "0.2.0"
 uuid = { version = "1.8.0", features = ["v4"] }
+tracing-subscriber = "0.3.17"
+tracing = { version = "0.1", features = ["log-always" ] }
 
 [build-dependencies]
 cbindgen = "0.26.0"

lib/srv/desktop/rdp/rdpclient/client.go

@@ -393,6 +393,15 @@ func (c *Client) startInputStreaming(stopCh chan struct{}) error {
 		c.UpdateClientActivity()
 
 		switch m := msg.(type) {
+		case tdp.ClientScreenSpec:
+			c.cfg.Logger.DebugContext(context.Background(), "Client changed screen size", "width", m.Width, "height", m.Height)
+			if errCode := C.client_write_screen_resize(
+				C.ulong(c.handle),
+				C.uint32_t(m.Width),
+				C.uint32_t(m.Height),
+			); errCode != C.ErrCodeSuccess {
+				return trace.Errorf("ClientScreenSpec: client_write_screen_resize: %v", errCode)
+			}
 		case tdp.MouseMove:
 			mouseX, mouseY = m.X, m.Y
 			if errCode := C.client_write_rdp_pointer(
@@ -694,8 +703,8 @@ func (c *Client) handleRDPFastPathPDU(data []byte) C.CGOErrCode {
 	return C.ErrCodeSuccess
 }
 
-//export cgo_handle_rdp_connection_initialized
-func cgo_handle_rdp_connection_initialized(
+//export cgo_handle_rdp_connection_activated
+func cgo_handle_rdp_connection_activated(
 	handle C.uintptr_t,
 	io_channel_id C.uint16_t,
 	user_channel_id C.uint16_t,
@@ -706,17 +715,17 @@ func cgo_handle_rdp_connection_initialized(
 	if err != nil {
 		return C.ErrCodeFailure
 	}
-	return client.handleRDPConnectionInitialized(io_channel_id, user_channel_id, screen_width, screen_height)
+	return client.handleRDPConnectionActivated(io_channel_id, user_channel_id, screen_width, screen_height)
 }
 
-func (c *Client) handleRDPConnectionInitialized(ioChannelID, userChannelID, screenWidth, screenHeight C.uint16_t) C.CGOErrCode {
-	c.cfg.Logger.DebugContext(context.Background(), "Received RDP channel IDs", "io_channel", ioChannelID, "user_channel", userChannelID)
+func (c *Client) handleRDPConnectionActivated(ioChannelID, userChannelID, screenWidth, screenHeight C.uint16_t) C.CGOErrCode {
+	c.cfg.Logger.DebugContext(context.Background(), "Received RDP channel IDs", "io_channel_id", ioChannelID, "user_channel_id", userChannelID)
 
 	// Note: RDP doesn't always use the resolution we asked for.
 	// This is especially true when we request dimensions that are not a multiple of 4.
 	c.cfg.Logger.DebugContext(context.Background(), "RDP server provided resolution", "width", screenWidth, "height", screenHeight)
 
-	if err := c.cfg.Conn.WriteMessage(tdp.ConnectionInitialized{
+	if err := c.cfg.Conn.WriteMessage(tdp.ConnectionActivated{
 		IOChannelID:   uint16(ioChannelID),
 		UserChannelID: uint16(userChannelID),
 		ScreenWidth:   uint16(screenWidth),