-
Notifications
You must be signed in to change notification settings - Fork 586
fix type for in memory cache factory #3000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1b3524f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Apollo Federation Subgraph Compatibility Results
Learn more: |
💻 Website PreviewThe latest changes are available as preview in: https://f481b3db.graphql-yoga.pages.dev |
✅ Benchmark Results |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-yoga/plugin-apq |
2.0.5-rc-20230920192600-1b3524fc |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-prometheus |
2.0.6-rc-20230920192600-1b3524fc |
npm ↗︎ unpkg ↗︎ |
@graphql-yoga/plugin-response-cache |
2.1.2-rc-20230920192600-1b3524fc |
npm ↗︎ unpkg ↗︎ |
|
@EmrysMyrddin could you avoid the runtime penalty by just reexporting a typecast function instead of making an additional nested function call? export const createInMemoryCache = envelopCreateInMemoryCache as (...args: Parameters<typeof envelopCreateInMemoryCache>) => Cache; |
|
@gthau You are totally right, it's better like this 👍 |
fixes #2905