Skip to content

chore: manual action for verifying deployments #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

spalladino
Copy link
Contributor

@spalladino spalladino commented Dec 1, 2022

Adds a manual github action for verifying deployments. The inputs to the action are the list of contracts to verify and their network. From that, the deployment addresses are picked up from addresses.json.

Screenshot from 2022-12-01 12-43-13

The verify job will use Defender's API to check that the compiled artifacts at that branch match the ones deployed. An example run can be seen here.

Screenshot from 2022-12-01 12-42-56

These results can also be manually checked on Defender after the verification was run.

Screenshot from 2022-12-01 12-42-26

This workflow requires defining the repository secrets:

  • DEFENDER_API_KEY
  • DEFENDER_API_SECRET
  • INFURA_KEY

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 91.59% // Head: 91.59% // No change to project coverage 👍

Coverage data is based on head (483eb40) compared to base (7eafa56).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #758   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          42       42           
  Lines        1999     1999           
  Branches      361      361           
=======================================
  Hits         1831     1831           
  Misses        168      168           
Flag Coverage Δ
unittests 91.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pcarranzav
pcarranzav previously approved these changes Dec 6, 2022
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Left a small comment but otherwise LGTM

@pcarranzav pcarranzav merged commit bc181d0 into graphprotocol:dev Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants