Skip to content

test: fix race condition in BridgeEscrow tests #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

pcarranzav
Copy link
Member

No description provided.

Copy link
Member

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Someday I'd like to use chai-as-promised which allows for expressions that look/read better imo.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 91.53% // Head: 91.53% // No change to project coverage 👍

Coverage data is based on head (323bdf8) compared to base (8aa3bd6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##           pcv/l2-bridge     #730   +/-   ##
==============================================
  Coverage          91.53%   91.53%           
==============================================
  Files                 42       42           
  Lines               1984     1984           
  Branches             346      346           
==============================================
  Hits                1816     1816           
  Misses               168      168           
Flag Coverage Δ
unittests 91.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcarranzav pcarranzav merged commit 323bdf8 into pcv/l2-bridge Oct 4, 2022
@pcarranzav pcarranzav deleted the pcv/fix-escrow-race branch November 10, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants