Skip to content

chore: provide sane defaults for graph config (dev branch) #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

tmigone
Copy link
Member

@tmigone tmigone commented Sep 28, 2022

Sets sane default values for GRE graph config file path. If necessary they can be overridden by using:

  • --l1-graph-config, --l2-graph-config or --graph-config on hardhat tasks
  • hre.graph({ graphConfig: '', l1GraphConfig: '', l2GraphConfig: ''}) when initializing GRE

Refer to GRE documentation for more details: https://github.com/graphprotocol/contracts/tree/dev/gre#configuration

Signed-off-by: Tomás Migone [email protected]

@tmigone tmigone force-pushed the tmigone/gre-defaults-dev branch from edeb5dd to 621c595 Compare September 28, 2022 22:46
@tmigone tmigone changed the title chore: provide sane defaults for graph config chore: provide sane defaults for graph config (dev branch) Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 90.57% // Head: 90.57% // No change to project coverage 👍

Coverage data is based on head (621c595) compared to base (45ce81e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #721   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          35       35           
  Lines        1762     1762           
  Branches      296      296           
=======================================
  Hits         1596     1596           
  Misses        166      166           
Flag Coverage Δ
unittests 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmigone tmigone merged commit 04cfd3a into dev Oct 3, 2022
@tmigone tmigone deleted the tmigone/gre-defaults-dev branch October 3, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants