Skip to content

feat(cli): add publish and mint using multicall #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

abarmat
Copy link
Contributor

@abarmat abarmat commented Sep 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 90.57% // Head: 90.57% // No change to project coverage 👍

Coverage data is based on head (9ceabbd) compared to base (af17480).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #713   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          35       35           
  Lines        1762     1762           
  Branches      296      296           
=======================================
  Hits         1596     1596           
  Misses        166      166           
Flag Coverage Δ
unittests 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only gripe is that I'd love to stop adding new commands to the cli and use hardhat tasks instead, but we can migrate them later as well.

@@ -46,20 +49,24 @@ export class IPFS {
export const pinMetadataToIPFS = async (
ipfs: string,
type: string,
path?: string, // Only pass path or metadata, not both
filepath?: string, // Only pass path or metadata, not both
Copy link
Member

@tmigone tmigone Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious if there was a ts trick to require only one of two properties:

type RequireOnlyOne<T, Keys extends keyof T = keyof T> =
    Pick<T, Exclude<keyof T, Keys>>
    & {
        [K in Keys]-?:
            Required<Pick<T, K>>
            & Partial<Record<Exclude<Keys, K>, undefined>>
    }[Keys]

I think we can stick with your code 😆

@abarmat abarmat merged commit 0ca43ff into dev Sep 27, 2022
@abarmat abarmat deleted the ab/cli-gns-multicall branch September 27, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants