Skip to content

some improvements in config files #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Conversation

pcarranzav
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Base: 91.51% // Head: 91.51% // No change to project coverage 👍

Coverage data is based on head (ffdca3b) compared to base (3f6c55e).
Patch coverage: 99.08% of modified lines in pull request are covered.

❗ Current head ffdca3b differs from pull request most recent head 80ef55a. Consider uploading reports for the commit 80ef55a to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           pcv/l2-bridge     #679   +/-   ##
==============================================
  Coverage          91.51%   91.51%           
==============================================
  Files                 41       41           
  Lines               1980     1980           
  Branches             346      346           
==============================================
  Hits                1812     1812           
  Misses               168      168           
Flag Coverage Δ
unittests 91.51% <99.08%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/governance/Managed.sol 94.54% <50.00%> (ø)
contracts/gateway/BridgeEscrow.sol 100.00% <100.00%> (ø)
contracts/gateway/GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/gateway/L1GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/l2/token/GraphTokenUpgradeable.sol 100.00% <100.00%> (ø)
contracts/l2/token/L2GraphToken.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcarranzav pcarranzav changed the title chore: syncAllContracts calls in all config files some improvements in config files Aug 11, 2022
@@ -172,7 +172,6 @@ export class NetworkFixture {
await staking.connect(deployer).setSlasher(slasherAddress, true)
await gns.connect(deployer).approveAll()
if (isL2) {
await grt.connect(deployer).addMinter(l2GraphTokenGateway.address)
Copy link
Contributor

@abarmat abarmat Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me why we removed the L2 bridge to be a minter in the fixture?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are already using the L2GraphToken.setGateway function to add it as the gateway minter, that can mint and burn through the bridgeMint and bridgeBurn functions.

@pcarranzav pcarranzav changed the base branch from l2-testnet to pcv/l2-bridge September 23, 2022 16:10
Copy link
Member

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit with theL2GraphToken config. It can be simplified from:

  L2GraphToken:
    proxy: true
    init:
      owner: "${{Env.deployer}}"
    calls:
      - fn: "renounceMinter"
      - fn: "transferOwnership"
        owner: *governor

to this:

  L2GraphToken:
    proxy: true
    init:
      owner: *governor

@pcarranzav pcarranzav merged commit 80ef55a into pcv/l2-bridge Sep 26, 2022
@pcarranzav pcarranzav deleted the pcv/sync-in-config branch November 10, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants