-
Notifications
You must be signed in to change notification settings - Fork 157
some improvements in config files #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 91.51% // Head: 91.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## pcv/l2-bridge #679 +/- ##
==============================================
Coverage 91.51% 91.51%
==============================================
Files 41 41
Lines 1980 1980
Branches 346 346
==============================================
Hits 1812 1812
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b5369e5
to
5ab5658
Compare
test/lib/fixtures.ts
Outdated
@@ -172,7 +172,6 @@ export class NetworkFixture { | |||
await staking.connect(deployer).setSlasher(slasherAddress, true) | |||
await gns.connect(deployer).approveAll() | |||
if (isL2) { | |||
await grt.connect(deployer).addMinter(l2GraphTokenGateway.address) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me why we removed the L2 bridge to be a minter in the fixture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we are already using the L2GraphToken.setGateway
function to add it as the gateway minter, that can mint and burn through the bridgeMint and bridgeBurn functions.
b4c831e
to
2bdfb06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit with theL2GraphToken
config. It can be simplified from:
L2GraphToken:
proxy: true
init:
owner: "${{Env.deployer}}"
calls:
- fn: "renounceMinter"
- fn: "transferOwnership"
owner: *governor
to this:
L2GraphToken:
proxy: true
init:
owner: *governor
8c8f6aa
to
3f6c55e
Compare
ffdca3b
to
80ef55a
Compare
No description provided.