-
Notifications
You must be signed in to change notification settings - Fork 157
scenario1: implement testnet validation step 1.2 #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## l2-testnet #670 +/- ##
===========================================
Coverage 92.13% 92.13%
===========================================
Files 44 44
Lines 2137 2137
Branches 370 370
===========================================
Hits 1969 1969
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
86e8495
to
1b47e88
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking good, I left a few comments.
@abarmat I'll work on addressing your comments but I think you didn't review the latest commit, I think you were on |
@abarmat, I'll reply to your comments now. Note that you didn't review the latest commit but an intermediate one. Some of your comments were addressed by later commits. In any case, since this PR is L1 exclusive and not using any of the new L1 features (reservoir, gateway) I'm cherry picking these commits into |
Commits from this PR have been cherry picked into #703 |
This PR implements step 1.2 on the L2 validation plan with a script plus a test file that can be run to assert the scenario.